Update testing environments #2321
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2321 +/- ##
==========================================
+ Coverage 86.84% 86.98% +0.14%
==========================================
Files 123 123
Lines 12745 12744 -1
==========================================
+ Hits 11068 11085 +17
+ Misses 1677 1659 -18 ☔ View full report in Codecov by Sentry. |
OriolAbril
force-pushed
the
numpy2
branch
2 times, most recently
from
56b861d
to
a7418c7
Compare
OriolAbril
changed the title
|
Should be ready to merge! |
| @@ -51,22 +58,20 @@ jobs: | |||
| python -m pip install --upgrade pip | |||
| python -m pip install wheel | |||
| python -m pip install --no-cache-dir -r requirements.txt | |||
| python -m pip install --no-cache-dir -r requirements-optional.txt | |||
There was a problem hiding this comment.
Are still using this file somewhere?
There was a problem hiding this comment.
Yes, all the jobs that now have the _optional suffix install the requirements in this file. It is done in the next step now though because it doesn't happen for all jobs and so needs its own condition to be evaluated.
The preview job currently installs xarray from github. With this change it won't install from github but it will install nigthly versions for xarray, numpy, scipy, h5py, matplotlib... So when it comes to xarray the behaviour is quite similar, at most testing on a day old nightly instead of exact present moment github version. But for all other scientific python libraries we will catch breaks and issues way earlier than we did before. |
Description
The initial goal of the PR was to test if ArviZ was already compatible with numpy 2.0 (which had just been pre-released as a beta version). Several dependencies weren't compatible yet, so it wasn't feasible to do. While waiting for this, we also saw ArviZ wasn't compatible with the latest scipy pre-release #2330, and the fix wasn't released before the actual release, generating many more issues like #2336. Moreover, even though the goal is to follow SPEC 0 guidance on dependency minimum version, having numba as optional dependency in fact pushes us the other way around, it often takes months after the release of a minor python version until we can incorporate it into our CI.
To try and handle all this, this PR updates our testing environments from 4 to 5. Now the environments are:
Checklist
📚 Documentation preview 📚: https://arviz--2321.org.readthedocs.build/en/2321/